Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Backport #2686 to 1.x-WorkingBranch #2784

Open
wants to merge 1 commit into
base: 1.x-WorkingBranch
Choose a base branch
from
Open

Backport #2686 to 1.x-WorkingBranch #2784

wants to merge 1 commit into from

Conversation

delarocka
Copy link

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the Nancy code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

The call to Task.Wait() causes a deadlock on many concurrent requests. This changes the method to do a synchronous copy instead.

Fixes #2781

@delarocka
Copy link
Author

"The command 'sudo apt-get update' failed and exited with 100 during". Seems like a problem with CI machine, can i somehow restart a build?

@phillip-haydon
Copy link
Member

I restarted it, failed with same error :( i donno what it's doing or why it's failing so someone started than me will need to look at it.

@NancyFx NancyFx deleted a comment from dnfclas Dec 11, 2017
@NancyFx NancyFx deleted a comment from dnfclas Dec 11, 2017
@cguedel
Copy link

cguedel commented Sep 17, 2018

Any reason why this was not yet merged to 1.x with a new release?

@delarocka
Copy link
Author

There was errors on CI build not related to code:
The command "sudo apt-get update" failed and exited with 100 during .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants