Feature/angular15 material legacy #3774
Merged
+14,900
−10,541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenkens
force-pushed
the
feature/angular15_material_legacy
branch
3 times, most recently
from
17d666a
to
fcf4351
Compare
mhenkens
force-pushed
the
feature/angular15_material_legacy
branch
9 times, most recently
from
6d9ccfc
to
ec5a3f9
Compare
mhenkens
force-pushed
the
feature/angular15_material_legacy
branch
from
ec5a3f9
to
fcf23f9
Compare
SuperITMan
requested changes
May 6, 2024
| @@ -15,39 +15,39 @@ | |||
| "url": "https://github.com/nationalbankbelgium/stark.git" | |||
| }, | |||
| "engines": { | |||
| "node": ">=14.20.0", | |||
| "npm": ">=8.19.1" | |||
| "node": ">=18.17.1", | |||
There was a problem hiding this comment.
Please adapt the value in the ".nvmrc" file:
18.17.1
package.json
Outdated
| @@ -39,13 +39,13 @@ | |||
| "@commitlint/config-conventional": "^18.6.0", | |||
| "@compodoc/compodoc": "1.1.19", | |||
| "@mdi/angular-material": "^4.0.96", | |||
| "@nationalbankbelgium/code-style": "^1.9.0", | |||
| "@nationalbankbelgium/code-style": "file:../code-style/dist/nationalbankbelgium-code-style-1.9.0.tgz", | |||
tsconfig.json
Outdated
There was a problem hiding this comment.
Please update the dependencies for each stark module then commit the changes in the main "package.json" at the same time.
For instance:
- Update the dependency "webpack-bundle-analyzer" to version "^4.10.1" in the main "package.json" file
- Update the dependency "webpack-bundle-analyzer" to version "^4.10.1" in the packages/stark-build/package.json file
- Commit the changes in the 3 files (2 package.json + 1 package-lock.json) and mention the updated library:
It could be a message like:feat(stark-build): update `webpack-bundle-analyzer` dependency to version `^4.10.1`
mhenkens
force-pushed
the
feature/angular15_material_legacy
branch
from
fcf23f9
to
3610514
Compare
mhenkens
force-pushed
the
feature/angular15_material_legacy
branch
5 times, most recently
from
ecdf057
to
c35d150
Compare
… `@uirouter/angular` dependencies Update node version in `.nvmrc`.
Run schematics to update to angular 15: `npx ng update @angular/core@15 @angular/cli@15 @angular/material@15`
Sync dependencies with root `package.json`. Update following dependencies: - `@angular-builders/custom-webpack` : `^15.0.0` - `webpack-bundle-analyzer` : `^4.10.1`
Sync dependencies with root `package.json`. Update following dependencies: - `@ng-idle/core`: `^13.0.1` - `@ng-idle/keepalive`: `^13.0.1` - `@ngrx/effects`: `^15.4.0` - `@ngrx/store`: `^15.4.0` - `@ngrx/store-devtools`: `^15.4.0` - `@ngx-translate/core`: `^14.0.0` - `@uirouter/angular`: `^11.1.0` Refactor `StarkSettingsEffects` class due to change in `typescript` configuration: - `"useDefineForClassFields": true`
Sync dependencies with root `package.json`. Update following dependency: - `@angular/material-moment-adapter`: `^15.2.9` Refactor Effects classes due to change in `typescript` configuration: - `"useDefineForClassFields": true`
Sync dependencies with root `package.json`. Update following dependencies: - `@angular-devkit/build-angular`: `^15.2.10` - `puppeteer`: `^22.4.0`
Refactor Effects classes due to change in `typescript` configuration: - `"useDefineForClassFields": true`
mhenkens
force-pushed
the
feature/angular15_material_legacy
branch
from
c35d150
to
ee7237e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Breaking change related to angular 15 and @angular/material@15
Other information