fix(core): sdkVersion and osVersion type adjustments

[NathanWalker]

PR Checklist

• The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• You have signed the CLA.
• All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
• Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Currently, both Device.sdkVersion and Device.osVersion return a number in Android. The typings state that this should be a string so expressions like if (Device.sdkVersion >= 23) {...} are not possible.

What is the new behavior?

I added number | string to the IDevice interface declaration so these expressions are allowed without the need to add @ts-ignore. I also updated the JSDoc to reflect this change.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4cfc742. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 2 targets

• nx run-many --target=test --configuration=ci --projects=core
• nx run webpack5:build

---

Sent with 💌 from NxCloud.

[NathanWalker]

See comments here