Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import runCLI off default export (fix #65) #66

Merged
merged 3 commits into from Apr 9, 2021

Conversation

jacobq
Copy link
Contributor

@jacobq jacobq commented Sep 21, 2020

@jacobq
Copy link
Contributor Author

jacobq commented Sep 21, 2020

Should also close #61 and #63

@sallaben
Copy link

sallaben commented Oct 8, 2020

Thank you! Hope this pr gets some attention

@stepheneb
Copy link

@jacobq thanks for temporarily publishing a package I can use until this pull request gets merged.

Running jest tests is working after replacing gulp-jest: ^4.0.3" with your package.

My current devDependencies:

"devDependencies": {
    "@babel/core": "^7.12.9",
    "@babel/preset-env": "^7.12.7",
    "@babel/preset-typescript": "^7.12.7",
    "babel-jest": "^26.6.3",
    "browser-sync": "^2.26.13",
    "esm": "^3.2.25",
    "gulp": "^4.0.2",
    "gulp-jest": "https://registry.npmjs.org/@jacobq/gulp-jest/-/gulp-jest-4.0.3-PR65.tgz",
    "gulp-sass": "^4.1.0",
    "jest": "^26.6.3",
    "jest-cli": "^26.6.3",
    "node-sass": "^5.0.0"
  }

@anthonyray
Copy link

Thanks @jacobq for this P.R. I tested with your temporary package and it works !

@aarontrank aarontrank merged commit d1da7df into Nerajno:master Apr 9, 2021
@jacobq jacobq deleted the fix-runCLI branch April 9, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

starting test with Jest 25 errors out with: "TypeError: Cannot read property 'runCLI' of undefined"
5 participants