Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for PAY_PER_REQUEST BillingMode #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mgwilliams
Copy link

No description provided.

@mgwilliams
Copy link
Author

@borgstrom It looks like the build failed due to no bump in version -- should I have opened the pull request to some other branch than master? Or are contributors expected to version bump? Or did I misunderstand the build failure?

@borgstrom borgstrom self-requested a review August 8, 2019 02:04
@borgstrom
Copy link
Contributor

Hi @mgwilliams,

Sorry for the delay! I was out on vacation/traveling.

Yes, can you please bump the version in setup.py and also fill out the CHANGELOG.rst.

Copy link
Contributor

@borgstrom borgstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The billing mode table attribute was added in botocore 1.12.54, which is supported in boto3 from 1.9.54 onward.

Can you please also set the minimum boto3 version to 1.9.54 in setup.py.

stream False str The stream view type, either None or one of:
'NEW_IMAGE'|'OLD_IMAGE'|'NEW_AND_OLD_IMAGES'|'KEYS_ONLY'

========= ======== ==== ===========
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is complaining about malformed RST here:

Warning, treated as error:
/home/travis/build/NerdWalletOSS/dynamorm/dynamorm/table.py:docstring of dynamorm.table:13:Malformed table.
Text in column margin in table line 7.

@borgstrom borgstrom mentioned this pull request Oct 1, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants