Make creator serializable #631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creator is instantiated with lambdas. We have been using hollow in pipeline environments and so being serializable by either the Java Serializer or others (like Kryo) need lambdas to be serializable as well.
|
@Sunjeet @stevenewald i was wondering if either of you could take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creator is instantiated with lambdas. We have been using hollow in pipeline environments and so being serializable by either the Java Serializer or others (like Kryo) need lambdas to be serializable as well. I am not sure if this change has any effect in hollow itself so feel free to reject it, but this would help my experience with Hollow right now