Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blobbasefee opcode #7043

Merged
merged 3 commits into from
May 21, 2024
Merged

fix blobbasefee opcode #7043

merged 3 commits into from
May 21, 2024

Conversation

yerke26
Copy link
Contributor

@yerke26 yerke26 commented May 17, 2024

Resolves #7059

Changes

  • List the changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... why is this a problem? IMO it is fine that this is nullable, tests before Cancun, definitely don't have this set. Maybe the difference should be how this null is handled later? And be sure if the block is post-cancun, to initialize cancun fields to default values, even if not provided.

Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
@NethermindEth NethermindEth deleted a comment from LukaszRozmej May 21, 2024
@yerke26 yerke26 merged commit 5abdc7d into master May 21, 2024
67 checks passed
@yerke26 yerke26 deleted the fix/cancun-blobbasefee-opcode branch May 21, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancun error with BLOBBASEFEE
3 participants