Skip to content

Commit

Permalink
Fix time_offset to be int to match RFC-2132
Browse files Browse the repository at this point in the history
https://datatracker.ietf.org/doc/html/rfc2132#section-3.4

time_offset (dhcp v4 option 2) should be int32, not uint32, as it can
indicate a time offset east (positive) or west (negative) of zero
meridian.
  • Loading branch information
ColinMcInnes authored and rsmarples committed Apr 27, 2024
1 parent 0fbd29b commit ad41d26
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/dhcpcd-definitions.conf
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ define 1 request ipaddress subnet_mask
# RFC3442 states that the CSR has to come before all other routes
# For completeness we also specify static routes then routers
define 121 rfc3442 classless_static_routes
define 2 uint32 time_offset
define 2 int32 time_offset
define 3 request array ipaddress routers
define 4 array ipaddress time_servers
define 5 array ipaddress ien116_name_servers
Expand Down

0 comments on commit ad41d26

Please sign in to comment.