Move dhcp(v4) packet size check earlier #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhcp_handlebootp handled zero sized packets correctly, but dhcp_redirect_dhcp did not have such protection. Move size check before both of them. Size when called from dhcp_packet is checked by is_packet_udp_bootp call. Only dhcp_recvmsg needs earlier checking to be added. Fixes NetworkConfiguration#283
pemensik
force-pushed
the
283-null-dhcp
branch
from
1c32fe3
to
cfa4e3e
Compare
|
Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dhcp_handlebootp handled zero sized packets correctly, but dhcp_redirect_dhcp did not have such protection. Move size check before both of them. Size when called from dhcp_packet is checked by is_packet_udp_bootp call. Only dhcp_recvmsg needs earlier checking to be added.
Fixes #283