Rgb over rpc #53
Draft
Rgb over rpc #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: applications/main/momentum_app/momentum_app.h modified: applications/main/momentum_app/scenes/momentum_app_scene_misc_screen.c modified: applications/main/momentum_app/scenes/momentum_app_scene_misc_vgm.c modified: applications/main/momentum_app/scenes/momentum_app_scene_misc_vgm_color.c modified: applications/services/rpc/rpc_gui.c modified: assets/protobuf modified: lib/drivers/rgb_backlight.c modified: lib/momentum/momentum.h modified: lib/toolbox/colors.c modified: lib/toolbox/colors.h modified: targets/f7/furi_hal/furi_hal_info.c modified: applications/external modified: applications/main/momentum_app/momentum_app.h modified: applications/main/momentum_app/scenes/momentum_app_scene_misc_screen.c modified: applications/main/momentum_app/scenes/momentum_app_scene_misc_vgm.c modified: applications/main/momentum_app/scenes/momentum_app_scene_misc_vgm_color.c modified: applications/services/rpc/rpc_gui.c modified: assets/protobuf modified: lib/drivers/rgb_backlight.c modified: lib/momentum/momentum.h modified: lib/toolbox/colors.c modified: lib/toolbox/colors.h modified: targets/f7/furi_hal/furi_hal_info.c
still not done refrash rate from flipper change and is slow so the rainbow mode doesnt look good modified: applications/main/momentum_app/scenes/momentum_app_scene_misc_vgm_color.c modified: applications/services/rpc/rpc_gui.c new file: lib/momentum/rpc_rgb.c new file: lib/momentum/rpc_rgb.h modified: lib/toolbox/colors.c modified: lib/toolbox/colors.h modified: targets/f7/api_symbols.csv
modified: applications/main/momentum_app/scenes/momentum_app_scene_misc_vgm.c modified: applications/services/rpc/rpc_gui.c modified: lib/momentum/momentum.h modified: lib/momentum/rpc_rgb.c modified: lib/momentum/rpc_rgb.h modified: applications/main/momentum_app/scenes/momentum_app_scene_misc_vgm.c modified: applications/services/rpc/rpc_gui.c modified: lib/momentum/momentum.h modified: lib/momentum/rpc_rgb.c modified: lib/momentum/rpc_rgb.h
…into rgb_over_rpc
Willy-JL
requested changes
May 17, 2024
| @@ -0,0 +1 @@ | |||
| #include "rpc_rgb.h" | |||
There was a problem hiding this comment.
Not anymore I could delete those files
There was a problem hiding this comment.
if this is now a fork, might need to update .gitmodules
| {"White", {0xFFFF}}, | ||
| {"Off", {{0, 0, 0}}}, | ||
| {"Rainbow", {{0, 0, 0}}}, | ||
| {"RgbMod", {{0, 0, 0}}}, |
There was a problem hiding this comment.
is the intent to set rainbow and rgbmod modes with the foreground and background toggles? if so, we can get rid of the other entry in the menu for "VGM Colors"
There was a problem hiding this comment.
Yes because you can now set the background or the foreground with rainbow and not one of them.
Wanted to ask if we should restructure or keep it like how I did it.
| FuriHalVersionColor spoof_color; | ||
| RgbColorTransmit vgm_color_fg; | ||
| RgbColorTransmit vgm_color_bg; |
There was a problem hiding this comment.
changing data type here, might be good to change name too so it is not imported incorrectly. then again, also need to update the code part in settings.c, so maybe can change it to save as hex and check data length instead of saving as uint32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
For the reviewer