-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wiki-js
recipe
#815
base: master
Are you sure you want to change the base?
Add wiki-js
recipe
#815
Conversation
793a572
to
adb0888
Compare
@drupol thanks for the PR! I think generally it's a great idea to present such example setups. Yours is particularly well-written in my opinion. Your proposal prompts the @NixOS/documentation-team to finally think in all seriousness about how to deal with those more generally. We've briefly discussed it before, but came to no conclusion because there were more pressing issues. Here are some considerations:
|
I generally think that NixOS modules should ideally Just Work™ with |
@fricklerhandwerk: I've developed a recipe that I believe could be beneficial to others in our community. Initially, I considered sharing it on https://nixos.wiki, but given that it's not an official platform, I'd prefer to centralize the documentation in a more official location. This led to my decision to submit a PR here. I'm open to suggestions on the best place to share this information. Once I have your guidance, I'll make the necessary adjustments to ensure it's posted in the most appropriate place. @infinisil: It seems that the feature isn't currently enabled (nixos/module). I agree that activating it would be interesting. I'm willing to explore this further and will look into what can be done to implement this idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only small nitpick.
Hi,
This is my first PR in this project.
Let me know if: