Inline the usage of nix::readDirectory
and remove it
#10684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nix::readDirectory
is removed.std::filesystem::directory_iterator
is used directly in places that used this util.Motivation
The
nix::readDirectory
usesstd::filesystem::directory_iterator
and pushes all the entries in astd::vector
before returning it. This is redundant as we can directly usestd::filesystem::directory_iterator
to iterate through entries and count files (and dirs) in path.Context
#9205
Priorities and Process
Add 馃憤 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.