-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.numpy: 1.19.4 -> 1.20.1 #111671
Conversation
Based on this comment, on the scikit-learn tracker, I believe that scikit-learn crash is reproduced on their CI and also not yet fixed, so I don't think there's a patch we can pull in yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should target staging
, not staging-next
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both commit messages should start with python3Packages
.
It's probably best not to break scikit-learn, since that package has a lot of reverse dependencies. Therefore, I think either I should disable the failing scikit-learn test, or we should wait to merge this PR until a patch is available from scikit-learn upstream, whichever ya'll think is best. |
I found the scikit-learn patch that makes it work with numpy 1.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 packages built:
python37Packages.matplotlib python37Packages.scikitlearn python38Packages.matplotlib python38Packages.scikitlearn python39Packages.matplotlib python39Packages.scikitlearn
Let's not merge this before I update the PR to 1.20.1 instead: https://mail.python.org/pipermail/scipy-dev/2021-February/024523.html |
Motivation for this change
https://numpy.org/devdocs/release/1.20.0-notes.html
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Based on joblib/joblib#1136 (and my testing), there's an incompatibility between numpy 1.20 and joblib <= 1.0, so I've also bumped joblib in this PR as well.
I did not rebuild everything since there are quite a lot of downstream packages that depend on
numpy
, but I did to a random selection of 62 packages:The failures are:
This is the scikit-learn failure: https://gist.github.com/rmcgibbo/21392d1c75d2c0809533bc3a97dce4ba