Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-desktop: 5.37.0 -> 5.38.0 #167769

Merged
merged 1 commit into from Apr 8, 2022

Conversation

teutat3s
Copy link
Member

@teutat3s teutat3s commented Apr 7, 2022

Description of changes

Bump signal-desktop version to 5.38.0
This includes an updated version in the bundled version of electron (17.3.1), which fixes a regression. It should no longer segfault on wayland.
signalapp/Signal-Desktop@a8962c7
https://github.com/electron/electron/releases/tag/v17.3.1
electron/electron#33499
#158175

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@klDen
Copy link
Member

klDen commented Apr 8, 2022

Result of nixpkgs-review pr 167769 run on x86_64-linux 1

1 package built:
  • signal-desktop

Copy link
Member

@klDen klDen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovesegfault lovesegfault merged commit 52e235a into NixOS:master Apr 8, 2022
@teutat3s teutat3s deleted the bump/signal-desktop branch April 9, 2022 22:23
@teutat3s
Copy link
Member Author

teutat3s commented Apr 9, 2022

@lovesegfault could you add the backport to release-21.11 label here, too? Thank you!

@github-actions
Copy link
Contributor

Successfully created backport PR #168139 for release-21.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants