Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparrow: 1.6.5 -> 1.7.0 #186508

Merged
merged 2 commits into from
Nov 9, 2022
Merged

sparrow: 1.6.5 -> 1.7.0 #186508

merged 2 commits into from
Nov 9, 2022

Conversation

emmanuelrosa
Copy link
Contributor

@emmanuelrosa emmanuelrosa commented Aug 13, 2022

Description of changes

There are two commits in this PR:

  1. Version bump from 1.6.5 to 1.7.0
  2. Add update.sh script

Notable changes:

  1. Addition of mimetypes to the .desktop file, per upstream.
  2. Update from OpenJDK 17 to OpenJDK 18, as required by upstream; The Java bytecode is incompatible with JDK 17.

Release notes:

Things done
  • Built on platform(s)
    • x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

Lassulus commented Nov 9, 2022

Result of nixpkgs-review pr 186508 run on x86_64-linux 1

1 package built:
  • sparrow

@Lassulus
Copy link
Member

Lassulus commented Nov 9, 2022

the openjdk version you use seem to be insecure, so NIXPKGS_ALLOW_INSECURE=1 was needed for evaluation

@Lassulus Lassulus merged commit 4de670e into NixOS:master Nov 9, 2022
@emmanuelrosa emmanuelrosa deleted the sparrow-1.6.6 branch November 10, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants