Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jabref: 5.6 -> 5.7 #189720

Merged
merged 1 commit into from
Sep 28, 2022
Merged

jabref: 5.6 -> 5.7 #189720

merged 1 commit into from
Sep 28, 2022

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Sep 4, 2022 •
edited

Description of changes
  1. lockfile is removed. There is no dynamic version used so it's not needed.
  2. Fix double wrapper.
  3. Fix wm class.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@linsui
Copy link
Contributor Author

linsui commented Sep 4, 2022

@ofborg build jabref

@ofborg ofborg bot requested a review from gebner September 4, 2022 12:38
@linsui
Copy link
Contributor Author

linsui commented Sep 16, 2022

@gebner Do you still maintain jabref?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/22

@MrTarantoga
Copy link
Contributor

You should also mark "Tested basic functionality of all binary files (usually in ./result/bin/)" in your PR. You said you tested it and verified the basic functionality?

@linsui linsui force-pushed the jabref branch 2 times, most recently from 6ce2b1a to c9af52f Compare September 19, 2022 03:11
@linsui
Copy link
Contributor Author

linsui commented Sep 20, 2022

What do you mean?

wamserma
wamserma approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, running via nix run github:NixOS/nixpkgs/pull/189720/merge#jabrefworked.

@wamserma
Copy link
Member

@SuperSandro2000 ping 4 merge

@SuperSandro2000 SuperSandro2000 merged commit 5a38d85 into NixOS:master Sep 28, 2022
@linsui linsui deleted the jabref branch September 29, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@linsui @nixos-discourse @MrTarantoga @wamserma @SuperSandro2000 @bobby285271