nodejs-18_x: fix cross compilation to aarch64-linux #189938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterqt
reviewed
Sep 6, 2022
There was a problem hiding this comment.
Might be better to fetchpatch nodejs/node#43200 and revert = true.
This adds a patch reverting nodejs/node#43200 because it breaks cross compilation to aarch64-linux. Gcc would not recognize the `-msign-return-address=all` flag causing compilation to fail.
IvarWithoutBones
force-pushed
the
node-cross
branch
from
a5b7857
to
71b8597
Compare
Done 👍 |
bjornfor
added
the
6.topic: cross-compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds a patch reverting nodejs/node#43200 because it breaks cross compilation to aarch64-linux. Gcc would not recognize the
-msign-return-address=allcommand-line flag causing compilation error out. This issue was most likely introduced with a recent update in #188253.Tested by compiling
pkgsCross.aarch64-multiplatfom.nodejs-slim.cc @cillianderoiste @gilligan @cko @marsam
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes