musl: 1.2.3 -> 1.2.5

[alyssais]

From a packaging perspective, this is the most important thing about this upgrade:

Users who build applications from source against musl should be aware: 1.2.4 deprecates the "LFS64" interfaces, which were provided via macros (causing lots of frustration by breaking things; thus the motivation to get rid of them).

Builds which break can be fixed for now by adding -D_LARGEFILE64_SOURCE to CFLAGS, but this too will be dropped in a later version.

Source

I think we should see which packages are affected, and give it some reasonable amount of time for them to be fixed, because I don't think it's going to always be as simple as modifying CFLAGS — what do we do for rustc, for example?

We also have some work ahead of us to even identify broken packages. I've done some test builds of the Spectrum live image, which heavily uses musl, to identify a few regressions, but since we don't have Hydra for musl, we're going to need people who use musl in Nixpkgs to do their own test builds to check whether any of the packages they care about are affected. If you do so, add any more broken packages to the list in this post (or comment if you lack permissions).

• LLVM llvm: backport patch for musl 1.2.4 #229442
• libselinux libselinux: remove use of LFS64 function #287471
• acl acl: backport patch for musl 1.2.4 #229440
• xorg.libpciaccess xorg.libpciaccess: backport patch for musl 1.2.4 #229441
• rustc (and cross-compiled programs that use non-musl build rustc) rustc: 1.72.1 -> 1.73.0 #259989
• gperftools gperftools: 2.10 -> 2.15 #253556
• gdb gdb: backport patch for musl 1.2.4 #229673
• doxygen doxygen: unvendor spdlog #292630
• libredirect libredirect: don't test LFS64 functions on musl #292616
• numactl numactl: 2.0.16 -> 2.0.17 #281724
• autogen autogen: patch out use of LFS64 functions #292617
• libeatmydata Fix sync_file_range() with musl 1.2.4 stewartsmith/libeatmydata#36
• bpftools
• libbpf
• gst_all_1.gstreamer
• meson meson: 1.3.2 -> 1.4.0 #298047
• elfutils elfutils: 0.190 -> 0.191 #293517
• yara yara: backport LFS64 removal #306531
• directfb directfb: use POSIX basename() #309583
• systemd linuxHeaders: 6.7 -> 6.9 #311995
• gpgme (Alpine patch) (Proposed upstream patch)
• mblaze mblaze: backport LFS64 removal #306517
• f2fs-tools f2fs-tools: backport LFS64 removal #306514
• ocamlPackages.uring ocamlPackages.uring: add patch for musl 1.2.5 #307693
• wgautomesh https://git.deuxfleurs.fr/Deuxfleurs/wgautomesh/pulls/7
• libfaketime libfaketime: backport LFS64 fix for musl 1.2.4 #313663
• aemu
• e2fsprogs (Alpine patch) (Upstream patch) e2fsprogs: 1.47.0 -> 1.47.1 #313657
• fuse2 (issue in fuse headers manifests in e2fsprogs after updating) (Void patch)
• mdadm (Alpine patch) (Proposed upstream patch) mdadm: fix build with musl 1.2.5 #313936
• xfsprogs https://termbin.com/8vdm xfsprogs: 6.6.0 -> 6.8.0 #304745
• multipath-tools multipath-tools: 0.9.6 -> 0.9.8; backport build fix for musl libc 1.2.5  #313682

Where we can fix things without breaking things for musl 1.2.3, let's apply those fixes in separate PRs, so the work can be more easily spread out, and avoid this one becoming intimidatingly huge.

Resources

• Alpine Linux's fixes

[alyssais]

#259989 includes the necessary Rust fixes, so will unblock this when merged.

[alyssais]

1.2.5 is out now, but it doesn't look like anything in that update will be nearly as hard as LFS in 1.2.4, so I'm now aiming to go straight to 1.2.5 with this. Help with reviewing the package fixes (the libselinux one has been open for a while) would be very helpful with getting this moving.

[fzakaria]

I opened #313439 didn't see it -- will close.

[fzakaria]

is there a Nix cache for musl ?
I'm stuck always rebuilding the world :)

[yu-re-ka]

There is no official cache for musl.
I sometimes feed my own cache https://cache.cyberchaos.dev/musl/

[fzakaria]

Would be cool to cook up an update script also for this.

[fzakaria]

Let me know how I can help.

I ran into issues building open office for musl due to NULL being #define as nullptr from this patch series -- figured I'd see if we were trying to upgrade first.

Let me know how I can help.

[alyssais]

Let me know how I can help.

Find packages that currently build, but don't build with this PR applied. (Or if you can't find any, let me know, that's also good data.)

[fzakaria]

Does nixpkgs with musl (non-static) even build at 1.2.3 ?
I found a few projects that were broken.

Is there a separate musl room on matrix or discord?

[fzakaria]

@alyssais I'll start a running list in this thread:

Trying to build openmpi

• pkgs/os-specific/linux/libpsm2/default.nix does not build.
  It uses drand48_data which is a non-standard libc extension in GLIBC.

  ptl_ips/ips_proto_recv.c:895:37: error: storage size of ‘drand48_data’ isn’t known
  895 |                 struct drand48_data drand48_data;
  

Trying to build libreoffice

• pkgs/development/libraries/CoinMP/default.nix
  It uses a reinterpreter_cast that causes failures as it's non compliant and musl disallows it.

[alyssais]

This isn't the place to collect a list of all packages that fail to build with musl. We're specifically interested in packages that do build with musl on current Nixpkgs, but fail with this PR applied. What you have posted look like packages that are already failing with musl, which are irrelevant for the purpose of upgrading.

[yu-re-ka]

Some rust programs are still broken?

   Compiling wgautomesh v0.1.0 (/build/source)
error: linking with `/nix/store/w90awkmiclfkryafwczz05dzah3d553k-armv7l-unknown-linux-musleabihf-gcc-wrapper-13.2.0/bin/armv7l-unknown-linux-musleabihf-cc` failed: exit status: 1
[...]
  |
  = note: /nix/store/33q0sjdwn8razm4dds94bzqkhm9q0g4n-armv7l-unknown-linux-musleabihf-binutils-2.41/bin/armv7l-unknown-linux-musleabihf-ld: /build/source/target/armv7-unknown-linux-musleabihf/release/deps/libgetrandom-a142f84e6b80c41b.rlib(getrandom-a142f84e6b80c41b.getrandom.249c8394be21b431-cgu.0.rcgu.o): in function `getrandom::getrandom':
          getrandom.249c8394be21b431-cgu.0:(.text._ZN9getrandom9getrandom17hcb85645c7b8dd976E+0x184): undefined reference to `open64'
          /nix/store/33q0sjdwn8razm4dds94bzqkhm9q0g4n-armv7l-unknown-linux-musleabihf-binutils-2.41/bin/armv7l-unknown-linux-musleabihf-ld: getrandom.249c8394be21b431-cgu.0:(.text._ZN9getrandom9getrandom17hcb85645c7b8dd976E+0x224): undefined reference to `open64'
          collect2: error: ld returned 1 exit status
          

[yu-re-ka]

Ah, all these programs need to bump their libc crate dependency...

[yu-re-ka]

Submitted deps bump upstream: https://git.deuxfleurs.fr/Deuxfleurs/wgautomesh/pulls/7

[alyssais]

@yu-re-ka can we keep them all in the big list in the PR body? Otherwise they're going to get hard to keep track of when GitHub starts hiding comments.