nix-health: init at 0.2.3 #261683
Merged
nix-health: init at 0.2.3 #261683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mindavi
requested changes
Oct 20, 2023
There was a problem hiding this comment.
OfBorg shows a fail for x86_64-darwin: https://logs.ofborg.org/?key=nixos/nixpkgs.261683&attempt_id=74d570ed-3d65-4ffb-b365-706bdde83e4f.
Otherwise looks ok
|
@Mindavi I just pushed the updated commit, fixing it by switching to nix-health uses the
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2828 |
Mindavi
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Packaging a new application called nix-health to check the health of the user's Nix install, allowing some customizations in the project flake.
https://github.com/juspay/nix-browser/tree/main/crates/nix_health#nix-health
I've tested and run this package on aarch64-darwin and x86_64-linux. I am both the author and will be the maintainer for this package.
The Nix expression is fairly similar to that of another Rust package I maintain, except for placing nix-health under
pkgs/by-name.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)