[Backport release-23.05] openssh: 9.3p2 -> 9.6p1

[leona-ya]

Description of changes

https://www.openssh.com/txt/release-9.6

unstable bump: #275249

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[kloenk]

LGTM

build on aarch64-darwin and aarch64-linux

[fpletz]

Any particular reason why you didn't cherry-pick -x the individual commits like we normally do for backporting? See https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes.

[leona-ya]

It seems wrong to do this, as it is a different upgrade (meaning: 9.3p2 -> 9.6p1 instead of 9.5p2 -> 9.6p1). But I can also cherry-pick, if I'm wrong

[risicle]

Normally we would cherry-pick all the intermediate bumps from the unstable branch.

[leona-ya]

Normally we would cherry-pick all the intermediate bumps from the unstable branch.

Okay, done that now

[risicle]

nixpkgs-review reveals no new failures, macos 12 x86_64, nixos x86_64. passthru.tests pass. pkgsMusl, pkgsCross.aarch64-multiplatform, pkgsi686Linux variants build.

Normally I'd probably argue we should be patching this instead because a 9.3 -> 9.6 jump is pretty big, but in this case I think we'd have trouble getting the patch ready before 23.05 goes EOL 🤷

[wegank]

Closing since NixOS 23.05 is EOL.

[pvgoran]

Closing since NixOS 23.05 is EOL.

Great, now 23.05 users are left without an (arguably) important security update. Even though it was ready for merge almost a week before EOL.

[pvgoran]

Much appreciated!