atuin: fix build on x86_64-darwin by updating to apple_sdk_11_0 #296054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, fails to build with:
```
> = note: Undefined symbols for architecture x86_64:
> "_kCFURLVolumeAvailableCapacityForImportantUsageKey", referenced from:
> sysinfo::unix::apple::disk::get_list::h5f0b9b2218314fb0 in libsysinfo-48f55e52227ea9a5.rlib(sysinfo-48f55e52227ea9a5.sysinfo.81d4345a26454b80-cgu.10.rcgu.o)
> ld: symbol(s) not found for architecture x86_64
> clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
>
>
> error: could not compile `atuin` (bin "atuin") due to 1 previous error
```
See NixOS#234678 for a similar fix on another package.
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 0
labels
|
@ofborg build atuin |
SuperSandro2000
approved these changes
Mar 15, 2024
0x4A6F
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Otherwise, fails to build with:
See #234678 for a similar fix on another package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.