Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helix: 24.07 -> 25.01 #370713

Merged
merged 1 commit into from
Jan 3, 2025
Merged

helix: 24.07 -> 25.01 #370713

merged 1 commit into from
Jan 3, 2025

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jan 3, 2025

Things done

Changelog: https://github.com/helix-editor/helix/blob/25.01/CHANGELOG.md

cc @zowoq @yusdacra @danth

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sorry, something went wrong.

@Defelo
Copy link
Member

Defelo commented Jan 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370713


x86_64-linux

✅ 2 packages built:
  • evil-helix
  • helix

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 3, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370713


x86_64-linux

✅ 2 packages built:
  • evil-helix
  • helix

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370713


x86_64-linux

✅ 2 packages built:
  • evil-helix
  • helix

x86_64-darwin

✅ 2 packages built:
  • evil-helix
  • helix

aarch64-darwin

✅ 2 packages built:
  • evil-helix
  • helix

@GaetanLepage GaetanLepage requested a review from drupol January 3, 2025 21:55
@drupol drupol merged commit 4246e8e into NixOS:master Jan 3, 2025
63 checks passed
@GaetanLepage GaetanLepage deleted the helix branch January 3, 2025 22:08
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-get-notified-when-a-package-is-updated/58333/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants