Add proxy support #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahCardoza
reviewed
Dec 13, 2020
| @@ -386,10 +386,12 @@ async function setupPage(ctx: RequestContext, params: BaseRequestAPICall, browse | |||
| const browserRequest = async (ctx: RequestContext, params: BaseRequestAPICall) => { | |||
| const oneTimeSession = params.session === undefined | |||
| const sessionId = params.session || UUIDv1() | |||
| const proxy = params.proxy; | |||
There was a problem hiding this comment.
Off the top of my head, I feel like this is more complicated than this... Have you tested this thoroughly?
There was a problem hiding this comment.
The logic behind it was added already. I just made it pass the proxy to the session
|
Will think work with this line here? Sorry, I don't have much time for testing right now. Line 128 in efc8b4a |
It should, as far as I remember |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.