fix: don't send sec-fetch-mode header #12299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a workaround for nodejs/undici#1305 required to remove Sec-Fetch-Mode header.
This is required because Threads seems to not return web-finger when Sec-Fetch-Mode is set to
cors/no-cors/same-originwhich are the only values NodeJS normally allows to set it to (despite the whole header making no sense on the server).I did it for the
requestmodule in general since it seemed easier than doing a special case for AP and also means nothing else will run into this issue in the future.