You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only two files that are kept are provider/MiningTimer.ts
and provider/utils/random.ts. These don't actually use the
Hardhat network, so they are not in the EDR repo.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I forgot to mention: I considered removing the stack traces tests, but then I decided not to, because much of the logic for them still lives on the Hardhat side. If we remove them, then we are effectively freezing the related code, and I'm not sure we want to do that yet.
The reason will be displayed to describe this comment to others. Learn more.
All the changes make sense. I'm not sure if we have anything else to remove, as I'm not fully aware of all the ERD-related code. If we missed something, we can remove it later. The workflow changes look good to me. I have no idea about the dev container 😅
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is of course impossible to review line by line. What I recommend doing is:
Brewfile.gitignore.github/workflows/hardhat-core-ci.yml.github/workflows/add-issue-to-project.yml.devcontainer/devcontainer.json.changeset/config.json