Address code review comments by Andy for deterministic packing.

NuGet · Jan 13, 2021 · b212126 · b212126
1 parent d89fcfb
commit b212126
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs b/src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs
@@ -926,7 +926,7 @@ private ZipArchiveEntry CreatePackageFileEntry(ZipArchive package, string entryN
                         PackagingLogMessage.CreateMessage(
                             string.Format(
                                 CultureInfo.CurrentCulture,
-                                Strings.ZipFileTimeStampModified, entryName, timeOffset.DateTime.ToShortDateString(), ZipFormatMinDate.ToShortDateString()),
+                                Strings.ZipFileTimeStampModified, entryName, timeOffset.DateTime.ToShortDateString(), ZipFormatMinDate.ToShortDateString(), ZipFormatMinDate.ToShortDateString(), ZipFormatMaxDate.ToShortDateString()),
                             LogLevel.Information));
                 }
 
@@ -942,7 +942,7 @@ private ZipArchiveEntry CreatePackageFileEntry(ZipArchive package, string entryN
                         PackagingLogMessage.CreateMessage(
                             string.Format(
                                 CultureInfo.CurrentCulture,
-                                Strings.ZipFileTimeStampModified, entryName, timeOffset.DateTime.ToShortDateString(), ZipFormatMinDate.ToShortDateString()),
+                                Strings.ZipFileTimeStampModified, entryName, timeOffset.DateTime.ToShortDateString(), ZipFormatMinDate.ToShortDateString(), ZipFormatMinDate.ToShortDateString(), ZipFormatMaxDate.ToShortDateString()),
                             LogLevel.Information));
                 }
 

diff --git a/src/NuGet.Core/NuGet.Packaging/Strings.Designer.cs b/src/NuGet.Core/NuGet.Packaging/Strings.Designer.cs
diff --git a/src/NuGet.Core/NuGet.Packaging/Strings.resx b/src/NuGet.Core/NuGet.Packaging/Strings.resx
@@ -864,9 +864,11 @@ Valid from:</comment>
     <comment>0 - property name</comment>
   </data>
   <data name="ZipFileTimeStampModified" xml:space="preserve">
-    <value>Last write timestamp for '{0}' changed from '{1}' to '{2}' because the zip file format does not support timestamp values before 01/01/1980 or after 12/31/2107.</value>
+    <value>Last write timestamp for '{0}' changed from '{1}' to '{2}' because the zip file format does not support timestamp values before {3} or after {4}.</value>
     <comment>0 - Entry name
 1 - original modified timestamp
-2 - new modified timestamp</comment>
+2 - new modified timestamp
+3 - Earliest date zip file supports
+4 - Latest date zip file supports</comment>
   </data>
-</root>
+</root>