Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGet pack "The DateTimeOffset specified cannot be converted into a Zip file timestamp" #3793
NuGet pack "The DateTimeOffset specified cannot be converted into a Zip file timestamp" #3793
Changes from 22 commits
1e0437f
57bb207
e45b889
d7bdb3c
18e3bf0
3f11fc4
5c9d833
ede2569
d89fcfb
b212126
146d4e5
7442f7b
dea0eef
bd1c76a
d9e5479
f24aff3
af38361
69161ae
a7f53aa
c5c3ebf
49cc7eb
5d812dc
b7737cb
fa51fa0
9bad83e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
warningMessage.Length -= Environment.NewLine.Length
will have better performance than.Trim()
. I'm assuming the only reason to call.Trim()
is to remove the trailing newline character(s).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed. Good trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the "Writing High Performance .NET Code" book,
string.Format
is much slower thanstring.Concat
(for which the+
operator is syntactic sugar.Although this method isn't on a hot path, so isn't itself perf-critical, I think it's good to practise these things all the time, so that it's natural when you are working on perf-critical code.
return Strings.ZipFileTimeStampModifiedWarning + Environment.NewLine + listOfFileTimeStampModifiedMessages;
, and remove{0}
from the resource files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed. I bought the book. Currently couldn't make time to read it.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.