Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo of issue#4983 reported to turborepo #926

Closed
wants to merge 1 commit into from

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented May 16, 2023

Reported turbo issue: vercel/turbo#4983

Problem: rollup's watch mode is killed by turbo, or not waited for?, hard to tell.

Reproduction steps:

  1. git clone git@github.com:NullVoxPopuli/limber.git
  2. cd limber
  3. git checkout how-to-get-turbo-rollup-watching
  4. pnpm i --ignore-scripts
  5. observe that in packages/ember-repl/addon/package.json the start script is rollup --config --watch
  6. try to start watch mode via turbo: pnpm turbo start --filter ember-repl
  7. observe that turbo exited, when it should have not-exited due to rollup being in watch mode
  8. cd packages/ember-repl/addon
  9. pnpm start
  10. observe that the start script in this package is a long-running watch mode that doesn't exit unless Ctrl+C is pressed (or some other kill/stop process signal is sent to the process)

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2023

⚠️ No Changeset found

Latest commit: 7b151d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NullVoxPopuli NullVoxPopuli marked this pull request as draft May 16, 2023 18:28
@NullVoxPopuli NullVoxPopuli changed the title Demo of issue reported to turborepo Demo of issue#4983 reported to turborepo May 16, 2023
@github-actions
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli force-pushed the how-to-get-turbo-rollup-watching branch from e86e75e to 7b151d2 Compare May 18, 2023 01:22
@NullVoxPopuli NullVoxPopuli deleted the how-to-get-turbo-rollup-watching branch February 6, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant