Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set/get default color implementation for Bullet DebugDrawer class #3052

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wil92
Copy link

@wil92 wil92 commented Mar 2, 2024

Currently, is only possible to debug OgreBullet wrapper with the default black wireframe color. The only workaround was possible if you create your own debug wrapper by inhering from the existing one and then overwriting set/get defaultColors methods involving a lot of code for such a simple thing.

@paroj
Copy link
Member

paroj commented Mar 2, 2024

with the default black wireframe color

the colors should not be all black by default:
https://github.com/bulletphysics/bullet3/blob/6bb8d1123d8a55d407b19fd3357c724d0f5c9d3c/src/LinearMath/btIDebugDraw.h#L40-L47

to fix the CI, you either have to ignore the new methods or rename the nested class as:

%rename(MaterialManager_Listener) Ogre::MaterialManager::Listener;

@wil92
Copy link
Author

wil92 commented Mar 2, 2024

@paroj, sorry for my ignorance, but not sure how could I ignore the methods or rename them, can you please share some documentation that I can follow to fix the pipelines?

About the color: m_deactivatedObject should be equal to btVector3(0, 1, 0) (green), but instead I got it rendered in black, this is why I said black. In any case, the idea is to be able to manipulate this color from the Ogre wrapper.

@paroj
Copy link
Member

paroj commented Mar 2, 2024

but not sure how could I ignore the methods or rename them

the renaming snipped is linked in my post

should be equal to btVector3(0, 1, 0) (green), but instead I got it rendered in black,

I looked into this, as it should have been working and its a typo:

f25eb7f

if the default colours work, is this PR still relevant?

@wil92 wil92 force-pushed the master branch 3 times, most recently from d495017 to fb0d5a2 Compare March 2, 2024 18:56
@wil92
Copy link
Author

wil92 commented Mar 2, 2024

@paroj, nice that you found the error. I don't need the change I made, but still, I think it could be good if someone would like to change the default color values. I was trying to fix the pipeline, but I honestly never worked with SWIG before, and I have no idea what to change to make it work. And I can't reproduce the error locally.

Guillermo Gonzalez added 2 commits March 2, 2024 20:49
Currently, is only possible to debug OgreBullet wrapper with the default black wireframe color. The only workaround was possible if you create your own debug wrapper by inhering from the existing one and then overwriting set/get defaultColors methods involving a lot of code for such a simple thing.
@paroj paroj marked this pull request as draft March 2, 2024 23:12
@paroj paroj added this to the 14.x milestone Mar 2, 2024
@paroj
Copy link
Member

paroj commented Mar 2, 2024

ok, lets keep it as a draft for now then. It would be difficult to merge now as the change breaks ABI in 14.2.x. I can come back for 14.3 to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants