-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set/get default color implementation for Bullet DebugDrawer class #3052
base: master
Are you sure you want to change the base?
Conversation
the colors should not be all black by default: to fix the CI, you either have to ignore the new methods or rename the nested class as: Line 734 in 1662ca0
|
@paroj, sorry for my ignorance, but not sure how could I ignore the methods or rename them, can you please share some documentation that I can follow to fix the pipelines? About the color: |
the renaming snipped is linked in my post
I looked into this, as it should have been working and its a typo: if the default colours work, is this PR still relevant? |
d495017
to
fb0d5a2
Compare
@paroj, nice that you found the error. I don't need the change I made, but still, I think it could be good if someone would like to change the default color values. I was trying to fix the pipeline, but I honestly never worked with SWIG before, and I have no idea what to change to make it work. And I can't reproduce the error locally. |
Currently, is only possible to debug OgreBullet wrapper with the default black wireframe color. The only workaround was possible if you create your own debug wrapper by inhering from the existing one and then overwriting set/get defaultColors methods involving a lot of code for such a simple thing.
ok, lets keep it as a draft for now then. It would be difficult to merge now as the change breaks ABI in 14.2.x. I can come back for 14.3 to this. |
Currently, is only possible to debug OgreBullet wrapper with the default black wireframe color. The only workaround was possible if you create your own debug wrapper by inhering from the existing one and then overwriting set/get defaultColors methods involving a lot of code for such a simple thing.