Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add new OGR driver for OpenDRIVE (XODR) #9504

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[WIP] Add new OGR driver for OpenDRIVE (XODR) #9504

wants to merge 14 commits into from

Commits on Jun 7, 2024

  1. Add new OGR driver for OpenDRIVE (XODR)

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    02f639b View commit details
    Browse the repository at this point in the history

  2. Switch to MIT license

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    23ac40a View commit details
    Browse the repository at this point in the history

  3. Implement review suggestions 

    - Refactor file opening
- Ensure m_ prefix for member variables
- Simplify for loops
- Use default member initializers
- Simplify and optimise manual memory management using std::unique_ptr
- Pass by const and reference where possible
- Use SetGeometryDirectly on features to avoid memory leaks
- Implement deferred driver loading capability as plugin, as per RFC 96
- Implement OGRGetNextFeatureThroughRaw
- Move XODR driver config to official Dockerfiles
- Add "test_ogrsf" compliance checking to Python tests
- Improve documentation
    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    f5bb234 View commit details
    Browse the repository at this point in the history

  4. Increment versionadded to 3.10

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    92aa52f View commit details
    Browse the repository at this point in the history

  5. Move libOpenDRIVE before libQB3 for correct order

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    911e720 View commit details
    Browse the repository at this point in the history

  6. Apply review suggestions for CI Dockerfiles

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    a373de1 View commit details
    Browse the repository at this point in the history

  7. Ensure cppcheck passes without errors 

    - Pass std::string by const reference
- Switch to postfix operators for non-primitive types
- Avoid virtual function calling from subclass constructors
    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    4268b6e View commit details
    Browse the repository at this point in the history

  8. Avoid calling ResetReading from constructor

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    12bfdc5 View commit details
    Browse the repository at this point in the history

  9. Add libOpenDRIVE config to Ubuntu 24.04 Dockerfile.ci

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1fcaad2 View commit details
    Browse the repository at this point in the history

  10. Implement new changes related to RFC96

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    8a31d43 View commit details
    Browse the repository at this point in the history

  11. Increment Ubuntu version in doc

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    f9c3620 View commit details
    Browse the repository at this point in the history

  12. Clean extension checking and file opening

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    646bec7 View commit details
    Browse the repository at this point in the history

  13. Adjust doc for ogrinfo --format XODR

    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    02ab5ea View commit details
    Browse the repository at this point in the history

  14. Rework MakeValid() and UnaryUnion() 

    Mark GEOS as mandatory dependency
    @michikommader
    michikommader committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    cb3283f View commit details
    Browse the repository at this point in the history