Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBNOpenDiskTree(): make it work with node descriptors with non-increasing nBinStart #114

Merged
merged 6 commits into from Mar 15, 2024
Merged

SBNOpenDiskTree(): make it work with node descriptors with non-increasing nBinStart #114

merged 6 commits into from Mar 15, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Mar 10, 2024

@rouault rouault force-pushed the fix_106 branch 4 times, most recently from fbd5628 to 8558818 Compare March 11, 2024 11:04
@thbeu
Copy link
Contributor

thbeu commented Mar 14, 2024

Would be useful to have at least some minimal test code for the SBN API in the repo. Currently there is none. See #106 (comment) for an example.

@rouault
Copy link
Member Author

rouault commented Mar 15, 2024

Would be useful to have at least some minimal test code for the SBN API in the repo

done

@thbeu
Copy link
Contributor

thbeu commented Mar 15, 2024

Would be useful to have at least some minimal test code for the SBN API in the repo

done

Please add all the new files to EXTRA_DIST in Makefile.am

@rouault
Copy link
Member Author

rouault commented Mar 15, 2024

Please add all the new files to EXTRA_DIST in Makefile.am

done. shapelib.def was also actually missing. I've fixed that. I've also modified the linux-autoconf CI config to actually do a cmake build on the tarball generated by makedist...

@rouault rouault merged commit 711b21e into OSGeo:master Mar 15, 2024
6 checks passed
@thbeu
Copy link
Contributor

thbeu commented Mar 15, 2024

Please add all the new files to EXTRA_DIST in Makefile.am

done. shapelib.def was also actually missing. I've fixed that. I've also modified the linux-autoconf CI config to actually do a cmake build on the tarball generated by makedist...

Very good. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive ? "ERROR 1: Inconsistent shape count for bin"
2 participants
@rouault @thbeu