Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CS: GraphQL Security Cheat Sheet #427

Closed
wants to merge 5 commits into from

Conversation

bigshebang
Copy link
Contributor

This PR covers issue #421

Don't crucify me, but I didn't check for any policy violations or use the New CS template. Just wanted to get my content here first as quickly as I could. I did check up with the conversion rules though and should be compliant with that.

This content is a copy (with small editing) of a quick cheat sheet I made for developers. I made this probably the same day that I started actually learning about breaking GraphQL and I'm still not very experienced testing it. I drew from online content like OWASP and Apollo GraphQL and from colleagues with more experience breaking GraphQL.

Some definite improvements that can be made:

  • Update format/layout to conform more with OWASP CS format
  • Some wording is uncertain due to unfamiliarity with GraphQL; this should be made to sound more confident
  • Actual code or config examples/snippets would probably be helpful
  • There are probably other hardening areas or potential attacks to consider that I missed

@ThunderSon ThunderSon marked this pull request as draft June 18, 2020 12:59
@ThunderSon
Copy link
Contributor

Had an initial quick skim over this. It looks like a nice place to grow it out into a beautiful CS. No crucifying for now.
The CS layout format is a really simple thing, we'll take care of that and send commits on this PR.

Set in draft mode till we're a bit more convinced on the structure and the potential of what it could contain.
Once we're done with that, we'll add it.

Next stage a larger expansion of it.

So first, have a robust skeleton with the details in there and with additional research. Second, making this into a full CS that is ready for production.

@jmanico
Copy link
Member

jmanico commented Jun 18, 2020 via email

@mackowski
Copy link
Collaborator

I like it so far! I will add some comments after @ThunderSon will update structure/format. Good job @bigshebang!

@bigshebang
Copy link
Contributor Author

Thanks all! Excited to get this CS out there for the world to use.

@ThunderSon
Copy link
Contributor

@bigshebang please create a new PR with a new branch. Master branches aren't fun playing with when things go sideways :)

@bigshebang bigshebang closed this Jun 22, 2020
@bigshebang
Copy link
Contributor Author

Moving this to a different PR with a new branch.

@bigshebang
Copy link
Contributor Author

See new PR here: #434.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants