Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Risk and Test - Backup Unencrypted [backup-unencrypted] #2604

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

e-a-security
Copy link
Collaborator

@e-a-security e-a-security commented Apr 16, 2024

This PR closes #2541.

@cpholguera cpholguera changed the title New Risk Development- Backup Unencrypted https://github.com/OWASP/owasp-mastg/issues/2541 Add Risk and Test - Backup Unencrypted [backup-unencrypted] Apr 27, 2024
@cpholguera
Copy link
Collaborator

Updated title and linking to issue in description (using the "closes #2541" statement).

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR @e-a-security! Here's some initial feedback to comply with our structure and guidelines. We'll do a more in-depth tech review after all this is fixed.

  • Remove any README.md files you have (you may be able to reuse the info in those files to create the missing test.md and example.md files, see below)
  • Add test.md files under each folder:
    • android-backup-unencrypted/test.md
    • ios-backup-unencrypted/test.md - Add example.md files and add number to the example folders:
    • android-backup-unencrypted/example-1/example.md
    • ios-backup-unencrypted/example-1/example.md
  • Fix the metadata in risk.md file, see the GitHub issue. This is called "yaml frontmatter" and is used in markdown files to enter metadata. It must follow the provided syntax including those --- delimiters and lowercase keys.
  • Rules have some predefined metadata, including a "summary" field which you can use to enter the description of each rule instead of using a README.md file. See one example here

See all guidelines here: https://docs.google.com/document/d/1EMsVdfrDBAu0gmjWAUEs60q-fWaOmDB5oecY9d9pOlg/edit?usp=sharing

At the beginning of that document you can find links to existing risks and tests so you can follow the same structure. If you still have questions after looking into that please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Risk - Backup Unencrypted [backup-unencrypted]
2 participants