New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for C++ project files and C & C++ files #1048
base: main
Are you sure you want to change the base?
Conversation
}, | ||
|
||
getLinkRegexes() { | ||
return [C_INCLUDE]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding an E2E test for this plugin as well. It doesn't have to be an E2E test for every single file extensions, maybe just a single one for .cpp
? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, there's a few things missing from this one still. I'll get it finished up over the weekend.
I agree, although it's not a huge problem, since the name is not user facing and mainly just confusing for contributes (maybe) |
<ClCompile Include="foo.cpp" /> | ||
|
||
<!-- @OctoLinkerDoesNotResolve --> | ||
<ClCompile Include="$(OutDir)strings.cpp"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanbuck this test failed because it didn't resolve the dependency, and when that happens OctoLinker still injects an <a>
but doesn't set the href
attribute. How do we want to handle that scenario?
This is what the html looks like for this line:
<td class="blob-code blob-code-addition">
<span class="blob-code-inner blob-code-marker" data-code-marker="+">
<
<span class="pl-ent">ClCompile</span>
<span class="pl-e">Include</span>
=
<span class="pl-s">
<span class="pl-pds">"</span>
<a data-pjax="true" class="octolinker-link">$(OutDir)strings.cpp</a>
<span class="pl-pds">"</span>
</span>
>
</span>
</td>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The false positives are resolved in #1069. Will rebase & finish up once that fix gets merged.
Checklist:
Example files:
Working on this made me realize the
dot-net-project
plugin should probably be renamed tomsbuild
since all of the files it handles are msbuild files and not specifically .net related.