Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linking to vscode extensions #1698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xt0rted
Copy link
Member

@xt0rted xt0rted commented Nov 13, 2022

While setting up a project recently I found myself having to link to the extensions I was adding in the PR so it was easier to review and figured it might be nice if we linked to them too.

From what I've found there's no easy API we can query to try to get the repo link for these which is kind of annoying. Here's all I was able to find on it microsoft/vsmarketplace#238.

Some example files I used while adding this in:

Checklist:

  • If this PR is a new feature, please provide at least one example link
  • Make sure all of the significant new logic is covered by tests

Copy link
Member

@stefanbuck stefanbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah would be nice if we could link to the repo, but we do the same for other things liker docker images so shouldn't be a big concern.

@xt0rted
Copy link
Member Author

xt0rted commented Dec 5, 2022

@stefanbuck the test failure looks to be related to #1702. I was getting similar errors in my projects before I fully moved to modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants