Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Defender identifies proc-macro-hack's transitive dependency artifacts as a threat #289

Closed
ErichDonGubler opened this issue Jul 15, 2022 · 5 comments
Labels
defect Something that isn't as or doesn't work as intended

Comments

@ErichDonGubler
Copy link

ErichDonGubler commented Jul 15, 2022

How To Reproduce

  1. Use a Windows 11 installation with up-to-date threat definitions for Windows Defender (as of 2022-07-15).

  2. Clone this project using Git.

  3. Run cargo build.

  4. Observe that Windows Defender will (eventually) flag files in the user's Temp folder as severe threats, like the following screenshot:

    image

    This can be expedited by navigating to %USERPROFILE%\AppData\Local in Windows Explorer and initiating a Quick Scan:

    image

Expected Outcome

Windows shouldn't be flagging this library's build artifacts as malicious...unless that's your intent! 😜

Actual Outcome

Windows flags a threat as described above.

Additional Details

@Ogeon
Copy link
Owner

Ogeon commented Jul 15, 2022

Huh, that's definitely not the intended effect! Thanks for notifying, I'll keep an eye on this for sure and see what can be done.

@ErichDonGubler
Copy link
Author

phf upstream has published v0.11.0, which contains the fix mentioned above. This seems like a straightforward fix now! 🎉

@Ogeon
Copy link
Owner

Ogeon commented Jul 16, 2022

Perfect! Thank you! 🎉 I'll see how far back I actually need to patch but I'll check 0.4, 0.5 and 0.6.

@Ogeon
Copy link
Owner

Ogeon commented Jul 16, 2022

Looks like it's only present in 0.6.0 among the published versions.

@bors bors bot closed this as completed in 2581263 Jul 16, 2022
@Ogeon
Copy link
Owner

Ogeon commented Jul 16, 2022

A 0.6.1 patch has been published and its changes have been merged up to the master branch.

Thanks once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something that isn't as or doesn't work as intended
Projects
None yet
Development

No branches or pull requests

2 participants