Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Defender identifies proc-macro-hack dependency artifacts as a threat #255

Closed
ErichDonGubler opened this issue Jul 15, 2022 · 0 comments · Fixed by #256
Closed

Windows Defender identifies proc-macro-hack dependency artifacts as a threat #255

ErichDonGubler opened this issue Jul 15, 2022 · 0 comments · Fixed by #256

Comments

@ErichDonGubler
Copy link
Contributor

ErichDonGubler commented Jul 15, 2022

Unfortunately, Windows has started identifying compilation artifacts from phf on my machine as a threat; this is because at least one proc-macro-hack artifact in the user's Temp folder are is identified as a threat:

image

Because the MSRV of this crate is 1.46, and upstream proc-macro-hack's repo README.md states:

Note: As of Rust 1.45 this crate is superseded by native support for #[proc_macro] in expression position. Only consider using this crate if you care about supporting compilers between 1.31 and 1.45.

...my conclusion is that phf and phf_macros should shed their proc-macro-hack dependencies as the best way to resolve this issue. Will file a PR shortly for this, as migration is a light lift.


Additional info:

@ErichDonGubler ErichDonGubler changed the title Windows Defender identifies proc-macro-hack transitive dependency as a threat Windows Defender identifies proc-macro-hack dependency artifacts as a threat Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant