Updated VSIX to be compatible with VS2019. (#1) #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al Studio. This feature will be required in Visual Studio 2019 Preview 2.
possibility022
approved these changes
Apr 19, 2019
|
If you deleted |
hansmbakker
suggested changes
Apr 25, 2019
| @@ -127,6 +124,7 @@ | |||
| </None> | |||
| <None Include="Templates\XmlGenerator.tt"> | |||
| <Generator>TextTemplatingFilePreprocessor</Generator> | |||
| <LastGenOutput>XmlGenerator1.cs</LastGenOutput> | |||
hansmbakker
reviewed
Apr 25, 2019
| <SpecificVersion>False</SpecificVersion> | ||
| <HintPath>..\lib\Microsoft.VisualStudio.Shell.11.0.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="Microsoft.VisualStudio.Shell.15.0, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" /> |
There was a problem hiding this comment.
This reference can be better consumed from a NuGet package:
https://www.nuget.org/packages/Microsoft.VisualStudio.Shell.15.0/
|
Maybe you can try the MetaPackage from mads |
|
Would you please merge this in so that we can install it |
@OmarElabd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Microsoft.VisualStudio.Shell.11.0 as a prerequisite as this was causing the install to fail in VS2019. Updated upper excluded version limits to 17.0, which is whatever version of Visual Studio that will come after VS2019.