Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core)!: remove hierarchy config #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bowheart
Copy link
Collaborator

Description

Remove the Store class's hierarchyConfig static property. This is a breaking change, but likely won't affect any Zedux users since we left this feature undocumented, intending to remove it.

The hierarchy config allowed stores to use different hierarchical data structures besides the default JS object. Zedux would then be able to intelligently merge nested reducers and stores together in e.g. an Immutable Map. Its setStateDeep would also use the hierarchyConfig

In practice, this is never used. Reducers are almost never used in Zedux and there's no point to using Immutable JS to wrap a simple child store mapping. It's easy to create an ImmutableJS zero-config store by setting that as the value and using setState on that value directly, ignoring setStateDeep.

If deeper functionality is needed, users are still able to extend the Store class (another undocumented feature) and modify absolutely everything. While that's more involved, it's probably necessary anyway - as it is, hierarchyConfig doesn't work intuitively for nested stores. Expanding Zedux's current hierarchyConfig model to cover all use cases would not be simple, would add codebase bloat, and would still never be used. Most importantly it would be redundant - since extending the Store class is already possible, we should make it the only way to add rarely-needed functionality like this.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

18 similar comments
@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trumid-prow
Copy link

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants