Skip to content

Commit

Permalink
Merge pull request #195 from OneSignal/native-version-update
Browse files Browse the repository at this point in the history
Native version update & major release
  • Loading branch information
emawby committed Sep 12, 2023
2 parents 495beb5 + 7102496 commit 9efebd9
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
8 changes: 4 additions & 4 deletions onesignal/withOneSignalAndroid.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Expo config plugin for One Signal (Android)
* Expo config plugin for OneSignal (Android)
* @see https://documentation.onesignal.com/docs/react-native-sdk-setup#step-4-install-for-ios-using-cocoapods-for-ios-apps
*/

Expand All @@ -13,16 +13,16 @@ import { existsSync, mkdirSync, writeFileSync } from 'fs';
const RESOURCE_ROOT_PATH = 'android/app/src/main/res/';

// The name of each small icon folder resource, and the icon size for that folder.
const SMALL_ICON_DIRS_TO_SIZE: { [name: string]: number } = {
'drawable-mdpi': 24,
const SMALL_ICON_DIRS_TO_SIZE: { [name: string]: number } = {
'drawable-mdpi': 24,
'drawable-hdpi': 36,
'drawable-xhdpi': 48,
'drawable-xxhdpi': 72,
'drawable-xxxhdpi': 96
};

// The name of each large icon folder resource, and the icon size for that folder.
const LARGE_ICON_DIRS_TO_SIZE: { [name: string]: number } = {
const LARGE_ICON_DIRS_TO_SIZE: { [name: string]: number } = {
'drawable-xxxhdpi': 256
};

Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "onesignal-expo-plugin",
"version": "1.3.2",
"version": "2.0.0",
"description": "The OneSignal Expo plugin allows you to use OneSignal without leaving the managed workflow. Developed in collaboration with SweetGreen.",
"main": "./app.plugin.js",
"scripts": {
Expand All @@ -25,7 +25,8 @@
"Karen Grigoryan",
"Rodrigo Gomez-Palacio",
"Charlie Cruzan",
"Wojciech Kozyra"
"Wojciech Kozyra",
"Brian Smith"
],
"license": "MIT",
"bugs": {
Expand Down
2 changes: 1 addition & 1 deletion support/iosConstants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export const TARGETED_DEVICE_FAMILY = `"1,2"`;

export const NSE_PODFILE_SNIPPET = `
target 'OneSignalNotificationServiceExtension' do
pod 'OneSignalXCFramework', '>= 3.0', '< 4.0'
pod 'OneSignalXCFramework', '>= 5.0', '< 6.0'
use_frameworks! :linkage => podfile_properties['ios.useFrameworks'].to_sym if podfile_properties['ios.useFrameworks']
end`;

Expand Down
2 changes: 1 addition & 1 deletion support/serviceExtensionFiles/NotificationService.m
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#import <OneSignal/OneSignal.h>
#import <OneSignalFramework/OneSignalFramework.h>

#import "NotificationService.h"

Expand Down

0 comments on commit 9efebd9

Please sign in to comment.