Merge JUST-series macros between oneflow/core/common and oneflow/maybe #10274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| } // namespace oneflow::maybe | ||
|
|
||
| #define TRY(...) JUST_STACK_CHECK_I(__VA_ARGS__) |
There was a problem hiding this comment.
我其实不太理解这个宏，这是 xinqi 加的
jackalcooper
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since JUST macros in oneflow/maybe can be more customizable and modular, we can replace JUST macros in oneflow/core/common with these in oneflow/maybe, so that all infra in oneflow/maybe can be introduced to the codebase without naming conflict. And it is also the first step to replace all old maybe infra (TODO: maybe a tracking issue is needed).