Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Tabbar, update page when not passing explicit prop in. #2367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

React Tabbar, update page when not passing explicit prop in. #2367

wants to merge 1 commit into from

Conversation

cjweigle
Copy link

@cjweigle cjweigle commented Mar 4, 2018

This fixed issue #2335 for me. I've only tested by wrapping the component, haven't had a chance to rebuild and test this patch to the library yet.

Wrapper for component:
https://gist.github.com/chronweigle/c7bf3b5a7ad21dbbb5110236439ad4f6

@asialgearoid
Copy link
Contributor

@chronweigle I'm not sure why this PR was not responded to originally, sorry for the delay.

I've tested it out, and it doesn't appear to actually fix the issue described in #2335. I can imagine this might fix issues where you were dynamically setting the active tab. However it does not seem to fix the issue where changing the actual tabs does not update the pages which the tabs relate to.

@cjweigle
Copy link
Author

cjweigle commented Aug 6, 2018

I mentioned I hadn't tested it. Looking at this now I see it shouldn't work. I missed hooking into the onPostChange callback as I did in the wrapper in the gist.

I've opened a new PR and provided an explanation. I spent more time providing an explanation of the problem than the solution since I don't know if this is the ideal solution. A proper understanding of the problem should lead you to a solution.

Thank you

#2508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants