add max-height attribute to ons-pull-hook #2721
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
When
threshold-height
attribute is a negative value, the pull hook should prevent itself from being pulled too far. And developer should be able to specify the max distance (max-height
attribute) a user can pull the componentCurrent behavior
When
threshold-height
attribute is a negative value, a user can pull the pull-hook component to an indefinite distance which may make the layout look weird.Proposed solution
The proposed the change adds an
max-height
attribute to theons-pull-hook
component, by which a developer can specify how far a user can pull it whenthreshold-height
is disabled.