Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max-height attribute to ons-pull-hook #2721

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StaymanHou
Copy link
Contributor

Expected behavior

When threshold-height attribute is a negative value, the pull hook should prevent itself from being pulled too far. And developer should be able to specify the max distance (max-height attribute) a user can pull the component

Current behavior

When threshold-height attribute is a negative value, a user can pull the pull-hook component to an indefinite distance which may make the layout look weird.

Proposed solution

The proposed the change adds an max-height attribute to the ons-pull-hook component, by which a developer can specify how far a user can pull it when threshold-height is disabled.

@StaymanHou StaymanHou marked this pull request as draft October 9, 2020 15:33
@StaymanHou StaymanHou marked this pull request as ready for review October 9, 2020 15:34
@StaymanHou
Copy link
Contributor Author

Hi, just wanted to follow up on this PR. Would the change be reviewed and merged? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant