Mok liee patch 2 #757
Closed
Mok liee patch 2 #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great, i was trying to do this in the same build workflow with conditions. i created a new branch on my fork to keep my tryings away from the PR. which way is preferable? split workflow or add conditions? |
|
let me think about it first. please put the work on hold for the time being |
|
the enhancement to support JAVA_HOME variable has been included in the latest release. please give it a try. thanks again for the PR. |
|
okay, let me know when i can help. i think i'll try a bit in my fork to learn more about github actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.