-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Use lombok for simple getters & setters #18559
base: master
Are you sure you want to change the base?
Conversation
02ed275
to
bad99fe
Compare
bad99fe
to
1a26907
Compare
@wing328 This PR was lying dormant for over two weeks as it appears the automatically assigned reviewer is unavailable. I've now rebased everything on Would love this to go in first so i can rebase my other open PRs on it (as it greatly simplfies things with ~3500 LOC saved). |
thanks for the PR. overall it looks good as it simplifies the code. can you please resolve the merge conflicts when you've time? we can definitely give it a try. |
1a26907
to
ac1152f
Compare
@wing328 Done! |
ac1152f
to
10342d9
Compare
10342d9
to
87dd1ba
Compare
87dd1ba
to
384ed27
Compare
As Lombok is available throughout the project and also used in a couple of places, we can use it to remove several thousand lines of boilerplate code. This PR applies mostly
@Getter
and@Setter
annotations wherever feasible, while not replacing any getter or setter methods that already have annotations (which could be facilitated via theonX
meta-annotation, however for now refraining from using it as it is still experimental).This makes the code base and – most importantly – the cognitive complexity to work through the repo considerably smaller. Also the declarative approach has the advantage that one can see immediately if a field is exposed in the public API by just looking at the declaration annotation.
This PR also contains some Javadoc and
@Override
annotation fixes and removes identical implementations in inherited classes.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)