-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update debug instruction for SSH Box #1425
Conversation
@@ -176,7 +176,9 @@ def start_ssh_session(self): | |||
else: | |||
username = 'root' | |||
logger.info( | |||
f"Connecting to {username}@{hostname} via ssh. If you encounter any issues, you can try `ssh -v -p {self._ssh_port} {username}@{hostname}` with the password '{self._ssh_password}' and report the issue on GitHub." | |||
f"Connecting to {username}@{hostname} via ssh. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let me check it on Monday, ref: astral-sh/ruff#7834 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, found that format was not ever called correctly; see #1457
but still not resolved fully the single-quote issues yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last resort would be to add flake8
back, maybe after ruff
, since flake8
only detects but doesn't do the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported in astral-sh/ruff#11209
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently they intentionally don't want to enforce quote behavior here. I think that's fine. We already disabled black's quote style fix in pyproject.toml
, so we won't see people's IDE plugins changing this line from single to double and from double to single endlessly (unless they manually do so).
Currently blocked by #1450 |
The current
ssh
instruction does not make sense for the DooD setup.This PR instructs the user to ssh to
localhost
for debugging purpose.