Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no response logging on async Feign #1450

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Fix no response logging on async Feign #1450

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54c6b7e
Fix no response logging on async Feign.
AWinterman Jun 30, 2021
11d6fce
Forgot a semicolon
AWinterman Jul 1, 2021
910ec66
Run license:format; make logLevel not final.
Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/src/main/java/feign/AsyncFeign.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2012-2020 The Feign Authors
* Copyright 2012-2021 The Feign Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
Expand Down Expand Up @@ -63,7 +63,7 @@ public static class AsyncBuilder<C> {
private Supplier<C> defaultContextSupplier = () -> null;
private AsyncClient<C> client;

private final Logger.Level logLevel = Logger.Level.NONE;
private Logger.Level logLevel = Logger.Level.NONE;
private final Logger logger = new NoOpLogger();

private Decoder decoder = new Decoder.Default();
Expand Down Expand Up @@ -159,6 +159,7 @@ public AsyncFeign<C> build() {
*/
public AsyncBuilder<C> logLevel(Logger.Level logLevel) {
builder.logLevel(logLevel);
this.logLevel = logLevel;
return this;
}

Expand Down