Fixed flaky tests in feign.json.JsonEncoderTest
#1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
reviewed
Nov 15, 2021
| } | ||
|
|
||
| @Test | ||
| public void encodesObject() { | ||
| new JsonEncoder().encode(jsonObject, JSONObject.class, requestTemplate); | ||
| assertEquals("{\"a\":\"b\",\"c\":1}", new String(requestTemplate.body(), UTF_8)); | ||
| JSONAssert.assertEquals("{\"a\":\"b\",\"c\":1}", new String(requestTemplate.body(), UTF_8),false); |
There was a problem hiding this comment.
probably going to fail due to code format....
build it locally, and maven will fix this for you
There was a problem hiding this comment.
Sorry for the format issue. I think I've fixed that now.
fixed format
Augustine-C
force-pushed
the
fix_flaky_tests
branch
from
e43c93e
to
e2b3dca
Compare
velo
approved these changes
Nov 15, 2021
This was referenced Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some flaky tests in
feign.json.JsonEncoderTestthat are caused by javaJSONObject's usage ofHashMap.Thus, the toString method for the
JSONObjectdoes not guarantee a deterministic output.This means that future changes in Java may change the order of the returned string, and cause tests failures in this file. I used a library
JSONAssertfromorg.skyscreamerto compare JSON strings. It compares the logical structure and data in the JSON object from the JSON string.