Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow a single content-type header to be applied while using googlehttpclient #1737

Conversation

skrzepto
Copy link
Contributor

@skrzepto skrzepto commented Sep 1, 2022

Impact

Fixed issue where multiple content-type headers were being added to the request while using googlehttpclient.

Research

Multiple Content-Type headers goes against the spec

Content-Type is defined as a singleton field....
https://www.rfc-editor.org/rfc/rfc9110.html#section-8.3-7

Implementation Summary

Ignore Content-Type from being set on the request because it'll be added via ByteArrayContent

@velo velo merged commit f09a72d into OpenFeign:master Sep 7, 2022
@skrzepto
Copy link
Contributor Author

@velo Thank you so much for merging in this pr! I was wondering when I can expect to see a build with this bug fix and if there's anything I can do to help.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants