Refactor coroutine feign #1754
Closed
Refactor coroutine feign #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wplong11
force-pushed
the
1-refactor-coroutine-feign
branch
from
0ccbbcf
to
9136d73
Compare
velo
requested changes
Sep 19, 2022
| .responseInterceptor(responseInterceptor) | ||
| .invocationHandlerFactory(invocationHandlerFactory) | ||
| .defaultContextSupplier((AsyncContextSupplier<Object>) defaultContextSupplier) | ||
| .methodInfoResolver(KotlinMethodInfo::createInstance) |
There was a problem hiding this comment.
shouldn't this be extracted to an attribute on the builder and let people override if needed?
Also, that is necessary to allow coroutine methodInfoResolver to be enriched
There was a problem hiding this comment.
Do you mean to allow the CoroutineBuilder to set the methodInfoResolver, and also provide an option to enrich the methodInfoResolver using Capability?
There was a problem hiding this comment.
I created a new PR #1762
wplong11
added a commit
to wplong11/feign
that referenced
this pull request
Sep 20, 2022
Work on the [feedback](OpenFeign#1754 (comment)) of PR OpenFeign#1754
velo
pushed a commit
that referenced
this pull request
Sep 20, 2022
* Add methodInfoResolver attribute to Coroutinebuilder Work on the [feedback](#1754 (comment)) of PR #1754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to see the final result, see PR #1757
Eliminates the possibility of breaking changes following AsyncFeign's refactoring in advance
TODO